Fix logging problem #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycq091044
approved these changes
Dec 7, 2022
| @@ -10,7 +10,10 @@ | |||
| os.makedirs(BASE_CACHE_PATH) | |||
|
|
|||
| # logging | |||
| logger = logging.getLogger() | |||
| logger = logging.getLogger(__name__) | |||
There was a problem hiding this comment.
Could I learn what does this change mean?
There was a problem hiding this comment.
logging.getLogger() gives you the root logger (shared by all applications using the logging module) while logging.getLogger(__name__) gives you a child logger (whose name is "pyhealth").
I changed this because we don't want to modify the behavior of the root logger which may be used outside of our package.
FYI: a good reference https://colab.research.google.com/github/aviadr1/learn-advanced-python/blob/master/content/15_logging/logging_in_python.ipynb
zzachw
added a commit
that referenced
this pull request
Dec 7, 2022
* fix duplicated logging problem * fix rnn dropout warning * reformat dataset statistics print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.