Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps (semver-major) #36

Merged
merged 4 commits into from
May 6, 2019
Merged

Update deps (semver-major) #36

merged 4 commits into from
May 6, 2019

Conversation

sam-github
Copy link
Contributor

Replaces #31

https://github.com/nodejs/Release

8, 10, and 12 are still supported

11 is supported until june 1

NOTE this is semver-major:

  1. Because it drops CI for old versions
  2. Because Buffer.from doesn't exist on out of support node versions (definitely not 0.10, I didn't check when it appears)
  3. The latest tap and debug don't suport 0.10 (and I didn't check what their earliest supported version is)

I suggest that it be merged and published as a major update after #35 lands (it currently is based off that branch).

@sam-github
Copy link
Contributor Author

I guess travis doesn't use the .travis.yml from this branch, but from master?

Failures on node < 8.x above were expected.

@sam-github
Copy link
Contributor Author

@msimerson

@msimerson
Copy link
Contributor

By replacing PRs instead of merging them from others you are discouraging contributors from submitting PRs.

@sam-github
Copy link
Contributor Author

sam-github commented May 3, 2019

I'm sorry you feel that way. I thought your interest was as an employee of IBM, I see now that I was wrong. I'd like you to reconsider how your comment

I'm over my head and don't know the solution.

from #31 (comment) would sound to someone like me who has the responsibility of supporting Loopback and IBM across Node.js.

Would you like authorship attribution on d965a1c and d9959ce ? I'm happy to do that (with your permission).

@msimerson
Copy link
Contributor

I'd like you to reconsider how your comment from would sound to someone like me who has the responsibility of supporting Loopback and IBM across Node.js.

I'm happy to consider it.

It doesn't change any of the facts on the ground. I'm a user of the syslog module that came along and invested some time and effort into improving it. Again. I created PRs that could have been merged. Instead of merging you create new commits that do the same things. What's an outside contributor to think? Especially since no outside PRs have ever been merged to this repo. Submitting PRs is contributing and common courtesy is to either request/suggest improvements if needed, and when they are good enough, merge them so the author gets attribution. Submitting PRs is permission and an implicit request.

@sam-github
Copy link
Contributor Author

I reassigned authorship to you for the two commits that update travis and package config.

@sam-github sam-github merged commit d5822e6 into master May 6, 2019
@sam-github sam-github deleted the update-deps branch May 6, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants