-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps (semver-major) #36
Conversation
I guess travis doesn't use the .travis.yml from this branch, but from master? Failures on node < 8.x above were expected. |
By replacing PRs instead of merging them from others you are discouraging contributors from submitting PRs. |
I'm sorry you feel that way. I thought your interest was as an employee of IBM, I see now that I was wrong. I'd like you to reconsider how your comment
from #31 (comment) would sound to someone like me who has the responsibility of supporting Loopback and IBM across Node.js. Would you like authorship attribution on d965a1c and d9959ce ? I'm happy to do that (with your permission). |
I'm happy to consider it. It doesn't change any of the facts on the ground. I'm a user of the syslog module that came along and invested some time and effort into improving it. Again. I created PRs that could have been merged. Instead of merging you create new commits that do the same things. What's an outside contributor to think? Especially since no outside PRs have ever been merged to this repo. Submitting PRs is contributing and common courtesy is to either request/suggest improvements if needed, and when they are good enough, merge them so the author gets attribution. Submitting PRs is permission and an implicit request. |
I reassigned authorship to you for the two commits that update travis and package config. |
Since it doesn't, move the comment about expected output on stderr into the message that is printed to stderr.
Replaces #31
https://github.com/nodejs/Release
8, 10, and 12 are still supported
11 is supported until june 1
NOTE this is semver-major:
I suggest that it be merged and published as a major update after #35 lands (it currently is based off that branch).