Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support node 12.x #35

Merged
merged 1 commit into from
May 6, 2019
Merged

support node 12.x #35

merged 1 commit into from
May 6, 2019

Conversation

sam-github
Copy link
Contributor

Adds support for node 12.x.

Note: this doesn't break support for anything, I tested all the .travis.yml platforms back to 0.10, and it still works, so this can be published as semver-minor (adds 12.x support, a new feature).

@sam-github
Copy link
Contributor Author

sam-github commented May 3, 2019

I tested with sucess on all the platforms, I'm curious to see what travis thinks:

git clean -x -d; nvm i 0.10; npm i && npm test; node --version
git clean -x -d; nvm i 0.12; npm i && npm test; node --version
git clean -x -d; nvm i 4; npm i && npm test; node --version
git clean -x -d; nvm i 5; npm i && npm test; node --version
git clean -x -d; nvm i 6; npm i && npm test; node --version
git clean -x -d; nvm i 8; npm i && npm test; node --version
git clean -x -d; nvm i 10; npm i && npm test; node --version
git clean -x -d; nvm i 11; npm i && npm test; node --version
git clean -x -d; nvm i 12; npm i && npm test; node --version

EDIT: tested on linux

@sam-github sam-github requested a review from bnoordhuis May 3, 2019 20:15
core.cc Show resolved Hide resolved
@sam-github
Copy link
Contributor Author

@msimerson

@msimerson
Copy link
Contributor

fixes #34

@sam-github sam-github merged commit b621c03 into master May 6, 2019
@sam-github sam-github deleted the support-12.x branch May 6, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants