Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dmidecode support in server-info for better view of memory subsystem #178

Merged
merged 18 commits into from
Dec 18, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added(server-info): using dmidecode memory data file for -show
  • Loading branch information
strizhechenko committed Dec 17, 2017
commit ffc32f9d29070a125ec83eb88892f0c50423d816
36 changes: 36 additions & 0 deletions netutils_linux_hardware/parsers.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,42 @@ class MemInfo(YAMLLike):
def parse(self, text):
return dict((k, int(v.replace(' kB', ''))) for k, v in iteritems(yaml.load(text)) if k in self.keys_required)

class MemInfoDMIDevice(object):
def __init__(self, text):
self.speed = 0
self.type = 'RAM'
self.handle = None
self.size = 0
for line in map(str.strip, text.split('\n')):
if line.startswith('Speed:'):
self.speed = line.split()[1]
elif line.startswith('Type:'):
self.type = line.split()[1]
elif line.startswith('Size:'):
self.size = line.split()[1]
elif line.startswith('Handle'):
self.handle = line.split(' ')[1].strip(',')


class MemInfoDMI(Parser):
@staticmethod
def parse(text):
if not text:
return None
output = dict()
for device in text.split('\n\n'):
if not 'Memory Device' in device:
continue
mem_dev = MemInfoDMIDevice(device)
if not mem_dev.handle:
continue
output[mem_dev.handle] = {
'type': mem_dev.type,
'speed': mem_dev.speed,
'size': mem_dev.size,
}
return output


class CPULayout(Parser):
@staticmethod
Expand Down
7 changes: 5 additions & 2 deletions netutils_linux_hardware/reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import os
import yaml
from netutils_linux_hardware.parsers import YAMLLike, CPULayout, DiskInfo, MemInfo
from netutils_linux_hardware.parsers import YAMLLike, CPULayout, DiskInfo, MemInfo, MemInfoDMI
from netutils_linux_hardware.netdev import ReaderNet


Expand All @@ -30,7 +30,10 @@ def gather_info(self):
},
'net': ReaderNet(self.datadir, self.path).netdevs,
'disk': DiskInfo().parse(self.path('disks_types'), self.path('lsblk_sizes'), self.path('lsblk_models')),
'memory': MemInfo().parse_file_safe(self.path('meminfo')),
'memory': {
'size': MemInfo().parse_file_safe(self.path('meminfo')),
'devices': MemInfoDMI().parse_file_safe(self.path('dmidecode')),
},
}
for key in ('CPU MHz', 'BogoMIPS'):
if self.info.get('cpu', {}).get('info', {}).get(key):
Expand Down