Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding dmidecode support in server-info for better view of memory subsystem #178

Merged
merged 18 commits into from
Dec 18, 2017
Merged

Adding dmidecode support in server-info for better view of memory subsystem #178

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
304c1b6
Added(server-info): reminder about installation pcituils and dmidecode.
strizhechenko Dec 17, 2017
ffc32f9
Added(server-info): using dmidecode memory data file for -show
strizhechenko Dec 17, 2017
a7c01fb
Added(test-data): server-info archive from cheapest vscale CentOS 7
strizhechenko Dec 17, 2017
df8928a
Added(server-info): memory device's type, speed and size rating in -r…
strizhechenko Dec 17, 2017
8994af6
Fixed(server info): Grade by known values didn't work
strizhechenko Dec 18, 2017
a83b2cc
Fixed(test-data): server-info show expected output.
strizhechenko Dec 18, 2017
4f43612
Formatting(parser.py).
strizhechenko Dec 18, 2017
a6e7195
Formatting(parser.py).
strizhechenko Dec 18, 2017
6b50976
Merge branch 'master' into dmidecode
strizhechenko Dec 18, 2017
bec2db8
Refactoring(dmi): extracted text parsing
strizhechenko Dec 18, 2017
d56f1ab
Refactoring(dmi): extracted text parsing
strizhechenko Dec 18, 2017
ba4b9d8
Refactoring(dmi): extracted text parsing
strizhechenko Dec 18, 2017
2964716
Incremented version
strizhechenko Dec 18, 2017
c9910d9
Refactoring(dmi): parser complexity fighting
strizhechenko Dec 18, 2017
c4d3b06
Refactoring(dmi): parser complexity fighting
strizhechenko Dec 18, 2017
d149194
Refactoring(dmi): parser complexity fighting
strizhechenko Dec 18, 2017
3f9d961
Refactoring(dmi): parser complexity fighting
strizhechenko Dec 18, 2017
557cbcf
Refactoring(parsers): provide optional way of init for any Parser-bas…
strizhechenko Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactoring(dmi): parser complexity fighting
  • Loading branch information
@strizhechenko
strizhechenko committed Dec 18, 2017
commit c9910d9c4ba539e0247e0e0c6827573a984b6afb
22 changes: 10 additions & 12 deletions netutils_linux_hardware/parsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,11 @@ def parse(self, text):

class MemInfoDMIDevice(object):
def __init__(self, text):
self.speed = 0
self.data = {
'speed': 0,
'type': 'RAM',
'size': 0,
}
self.type = 'RAM'
self.handle = None
self.size = 0
Expand All @@ -136,19 +140,13 @@ def parse_text(self, text):
self.parse_line(line)

def parse_line(self, line):
if line.startswith('Speed:'):
self.speed = MemInfoDMIDevice.get_value(line)
elif line.startswith('Type:'):
self.type = MemInfoDMIDevice.get_value(line)
elif line.startswith('Size:'):
self.size = MemInfoDMIDevice.get_value(line)
elif line.startswith('Handle'):
for key in ('Speed', 'Type', 'Size'):
if line.startswith(key + ':'):
self.data[key.lower()] = line.split()[1]
break
if line.startswith('Handle'):
self.handle = line.split(' ')[1].strip(',')

@staticmethod
def get_value(line):
return line.split()[1]


class MemInfoDMI(Parser):
@staticmethod
Expand Down