Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdr, keypair: Add helpers to create CAP-40 decorated signatures #4302

Merged
merged 8 commits into from
Mar 23, 2022
Merged

xdr, keypair: Add helpers to create CAP-40 decorated signatures #4302

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd6a1c2
Add decorated signature methods for signed payloads
Shaptic Mar 22, 2022
1b155d1
Simplify decorated signature creation
Shaptic Mar 23, 2022
69b50bd
Rename method, split subtests
Shaptic Mar 23, 2022
f63acb7
Correct and clean up test cases
Shaptic Mar 23, 2022
fb2a5fa
Change docstring verbiage: signers aren't always keys
Shaptic Mar 23, 2022
f89c9d7
Explain method purpose better
Shaptic Mar 23, 2022
0498dc6
Avoid magic constants
Shaptic Mar 23, 2022
d37806d
Separate test cases, add 0-len test
Shaptic Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid magic constants 
Co-authored-by: Leigh McCulloch <[email protected]>
  • Loading branch information
@Shaptic @leighmcculloch
Shaptic and leighmcculloch committed Mar 23, 2022
commit 0498dc686f6fe50c6b51478c3c252236bc98efd6
2 changes: 1 addition & 1 deletion xdr/decorated_signature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func NewDecoratedSignatureForPayload(
hint := [4]byte{}
// copy the last four bytes of the payload into the hint
if len(payload) >= len(hint) {
copy(hint[:], payload[len(payload)-4:])
copy(hint[:], payload[len(payload)-len(hint):])
} else {
copy(hint[:], payload[:])
}
Expand Down