Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdr, keypair: Add helpers to create CAP-40 decorated signatures #4302

Merged
merged 8 commits into from
Mar 23, 2022
Merged

xdr, keypair: Add helpers to create CAP-40 decorated signatures #4302

merged 8 commits into from
Mar 23, 2022

Commits on Mar 22, 2022

  1. Add decorated signature methods for signed payloads

    @Shaptic
    Shaptic committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    fd6a1c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Simplify decorated signature creation

    @Shaptic
    Shaptic committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    1b155d1 View commit details
    Browse the repository at this point in the history

  2. Rename method, split subtests

    @Shaptic
    Shaptic committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    69b50bd View commit details
    Browse the repository at this point in the history

  3. Correct and clean up test cases

    @Shaptic
    Shaptic committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    f63acb7 View commit details
    Browse the repository at this point in the history

  4. Change docstring verbiage: signers aren't always keys 

    Co-authored-by: Leigh McCulloch <[email protected]>
    @Shaptic @leighmcculloch
    Shaptic and leighmcculloch committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    fb2a5fa View commit details
    Browse the repository at this point in the history

  5. Explain method purpose better 

    Co-authored-by: Leigh McCulloch <[email protected]>
    @Shaptic @leighmcculloch
    Shaptic and leighmcculloch committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    f89c9d7 View commit details
    Browse the repository at this point in the history

  6. Avoid magic constants 

    Co-authored-by: Leigh McCulloch <[email protected]>
    @Shaptic @leighmcculloch
    Shaptic and leighmcculloch committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    0498dc6 View commit details
    Browse the repository at this point in the history

  7. Separate test cases, add 0-len test

    @Shaptic
    Shaptic committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    d37806d View commit details
    Browse the repository at this point in the history