Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon: Support new CAP-21 transaction conditions #4297

Merged
merged 22 commits into from
Mar 25, 2022
Merged

services/horizon: Support new CAP-21 transaction conditions #4297

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d28c2ca
Add cap-21 transaction preconditions
Mar 17, 2022
cd8277a
Replace xdr.TransactionEnvelope.TimeBounds -> .Preconditions function
Mar 21, 2022
ac3fb54
Rename Signers -> ExtraSigners for more consistent naming
Mar 21, 2022
3d73d12
Store the new precondition fields in the DB
Mar 21, 2022
fc1057c
Render the new precondition fields in the resourceadapter
Mar 21, 2022
64ce98e
./gogenerate.sh
Mar 21, 2022
2b13140
use a pointer so omitempty works
Mar 21, 2022
cbe15b7
more consistent naming
Mar 21, 2022
fffacc5
Keep Timebounds helper
Mar 21, 2022
bc02876
PR feedback
Mar 22, 2022
9174f76
tidy transaction precondition helpers
Mar 22, 2022
3cdb667
typo fixes
Mar 22, 2022
b646879
remove dead param
Mar 22, 2022
3104a13
use bigint so we have enough space for a uint32
Mar 23, 2022
4574288
use text instead of varchar, to avoid future migrations
Mar 23, 2022
de9bca3
Updating scenario sqls
Mar 23, 2022
c7115b2
need to load the preconditions from the db
Mar 24, 2022
4e61c0f
Temporary passing data for v2 preconditions transaction insertion test
Mar 25, 2022
4248a0c
Update xdr/transaction_envelope_test.go
Mar 25, 2022
a400725
Update services/horizon/internal/db2/history/transaction_ledger_bound…
Mar 25, 2022
7290be4
PR feedback
Mar 25, 2022
b7807a2
Merge remote-tracking branch 'origin/horizon-protocol-19' into update…
Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use text instead of varchar, to avoid future migrations
  • Loading branch information
Paul Bellamy committed Mar 23, 2022
commit 4574288d92676f95a3c6cdc4c70e432c5d3377e3
5 changes: 3 additions & 2 deletions services/horizon/internal/db2/schema/migrations/54_bigger_account_signers.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
-- +migrate Up

-- CAP-40 signed payload strkeys can be 165 characters long, see
-- strkey/main.go:maxEncodedSize
-- strkey/main.go:maxEncodedSize. But we use text here, so we don't need to
-- adjust it *ever again*.
paulbellamy marked this conversation as resolved.
Show resolved Hide resolved
ALTER TABLE accounts_signers
ALTER COLUMN signer TYPE character varying(165);
ALTER COLUMN signer TYPE text;

-- +migrate Down
ALTER TABLE accounts_signers
Expand Down
2 changes: 1 addition & 1 deletion services/horizon/internal/db2/schema/migrations/55_protocol_19.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ ALTER TABLE history_transactions ADD ledger_bounds int8range;
ALTER TABLE history_transactions ADD min_account_sequence bigint;
ALTER TABLE history_transactions ADD min_account_sequence_age bigint;
ALTER TABLE history_transactions ADD min_account_sequence_ledger_gap bigint;
ALTER TABLE history_transactions ADD extra_signers character varying(165)[];
ALTER TABLE history_transactions ADD extra_signers text[];

-- +migrate Down
ALTER TABLE history_transactions DROP ledger_bounds;
Expand Down