Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon: Support new CAP-21 transaction conditions #4297

Merged
merged 22 commits into from
Mar 25, 2022
Merged

services/horizon: Support new CAP-21 transaction conditions #4297

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d28c2ca
Add cap-21 transaction preconditions
Mar 17, 2022
cd8277a
Replace xdr.TransactionEnvelope.TimeBounds -> .Preconditions function
Mar 21, 2022
ac3fb54
Rename Signers -> ExtraSigners for more consistent naming
Mar 21, 2022
3d73d12
Store the new precondition fields in the DB
Mar 21, 2022
fc1057c
Render the new precondition fields in the resourceadapter
Mar 21, 2022
64ce98e
./gogenerate.sh
Mar 21, 2022
2b13140
use a pointer so omitempty works
Mar 21, 2022
cbe15b7
more consistent naming
Mar 21, 2022
fffacc5
Keep Timebounds helper
Mar 21, 2022
bc02876
PR feedback
Mar 22, 2022
9174f76
tidy transaction precondition helpers
Mar 22, 2022
3cdb667
typo fixes
Mar 22, 2022
b646879
remove dead param
Mar 22, 2022
3104a13
use bigint so we have enough space for a uint32
Mar 23, 2022
4574288
use text instead of varchar, to avoid future migrations
Mar 23, 2022
de9bca3
Updating scenario sqls
Mar 23, 2022
c7115b2
need to load the preconditions from the db
Mar 24, 2022
4e61c0f
Temporary passing data for v2 preconditions transaction insertion test
Mar 25, 2022
4248a0c
Update xdr/transaction_envelope_test.go
Mar 25, 2022
a400725
Update services/horizon/internal/db2/history/transaction_ledger_bound…
Mar 25, 2022
7290be4
PR feedback
Mar 25, 2022
b7807a2
Merge remote-tracking branch 'origin/horizon-protocol-19' into update…
Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo fixes
  • Loading branch information
Paul Bellamy committed Mar 22, 2022
commit 3cdb66773f5b3fa3b5a93f16e123795a63bcf6f1
38 changes: 19 additions & 19 deletions xdr/transaction_envelope.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func (e TransactionEnvelope) Signatures() []DecoratedSignature {
}
}

// SeqNum returns the sequence number set in the transaction envelope
// SeqNum returns the sequence number set in the transaction envelope.
// Note for fee bump transactions, SeqNum() returns the sequence number
// of the inner transaction
func (e TransactionEnvelope) SeqNum() int64 {
Expand All @@ -87,9 +87,9 @@ func (e TransactionEnvelope) SeqNum() int64 {
}
}

// TimeBounds returns the time bounds set in the transaction envelope
// Note for fee bump transactions, TimeBounds() returns the time bounds
// of the inner transaction
// TimeBounds returns the time bounds set in the transaction envelope. Note for
// fee bump transactions, TimeBounds() returns the time bounds of the inner
// transaction
func (e TransactionEnvelope) TimeBounds() *TimeBounds {
switch e.Type {
case EnvelopeTypeEnvelopeTypeTxFeeBump:
Expand All @@ -103,9 +103,9 @@ func (e TransactionEnvelope) TimeBounds() *TimeBounds {
}
}

// LedgerBounds returns the ledger bounds set in the transaction envelope
// Note for fee bump transactions, TimeBounds() returns the ledger bounds
// of the inner transaction
// LedgerBounds returns the ledger bounds set in the transaction envelope. Note
// for fee bump transactions, LedgerBounds() returns the ledger bounds of the
// inner transaction
func (e TransactionEnvelope) LedgerBounds() *LedgerBounds {
switch e.Type {
case EnvelopeTypeEnvelopeTypeTxFeeBump:
Expand All @@ -119,9 +119,9 @@ func (e TransactionEnvelope) LedgerBounds() *LedgerBounds {
}
}

// MinSeqNum returns the min seq num set in the transaction envelope
// Note for fee bump transactions, TimeBounds() returns the value
// of the inner transaction
// MinSeqNum returns the min seq num set in the transaction envelope. Note for
// fee bump transactions, MinSeqNum() returns the field from the inner
// transaction
func (e TransactionEnvelope) MinSeqNum() *SequenceNumber {
switch e.Type {
case EnvelopeTypeEnvelopeTypeTxFeeBump:
Expand All @@ -135,9 +135,9 @@ func (e TransactionEnvelope) MinSeqNum() *SequenceNumber {
}
}

// MinSeqAge returns the min seq age set in the transaction envelope
// Note for fee bump transactions, TimeBounds() returns the value
// of the inner transaction
// MinSeqAge returns the min seq age set in the transaction envelope. Note for
// fee bump transactions, MinSeqAge() returns the field from the inner
// transaction
func (e TransactionEnvelope) MinSeqAge() *Duration {
switch e.Type {
case EnvelopeTypeEnvelopeTypeTxFeeBump:
Expand All @@ -151,9 +151,9 @@ func (e TransactionEnvelope) MinSeqAge() *Duration {
}
}

// MinSeqLedgerGap returns the min seq ledger gap set in the transaction envelope
// Note for fee bump transactions, TimeBounds() returns the value
// of the inner transaction
// MinSeqLedgerGap returns the min seq ledger gap set in the transaction.
// envelope. Note for fee bump transactions, MinSeqLedgerGap() returns the
// field from the inner transaction
func (e TransactionEnvelope) MinSeqLedgerGap() *Uint32 {
switch e.Type {
case EnvelopeTypeEnvelopeTypeTxFeeBump:
Expand All @@ -167,9 +167,9 @@ func (e TransactionEnvelope) MinSeqLedgerGap() *Uint32 {
}
}

// ExtraSigners returns the extra signers set in the transaction envelope
// Note for fee bump transactions, TimeBounds() returns the value
// of the inner transaction
// ExtraSigners returns the extra signers set in the transaction envelope. Note
// for fee bump transactions, ExtraSigners() returns the field from the inner
// transaction
func (e TransactionEnvelope) ExtraSigners() []SignerKey {
switch e.Type {
case EnvelopeTypeEnvelopeTypeTxFeeBump:
Expand Down