Add support for launching Geth and Nimbus-eth1 nodes in launch_local_testnet #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
reviewed
Jun 22, 2022
scripts/launch_local_testnet.sh
Outdated
| @@ -72,7 +82,20 @@ ETH2_DOCKER_IMAGE="" | |||
| REMOTE_SIGNER_NODES=0 | |||
| REMOTE_SIGNER_THRESHOLD=1 | |||
| REMOTE_VALIDATORS_COUNT=0 | |||
| LC_NODES=1 | |||
| LC_NODES=0 | |||
There was a problem hiding this comment.
I'm not sure how this came to be, but it looks like the network is failing to finalize when there are some light nodes under the new regime here. I've pushed LC_NODES=1, so you can take a look at the logs.
There was a problem hiding this comment.
Seems like it finalizes properly.
There was a problem hiding this comment.
It fails locally, but alright, we can keep investigating this after merging.
etan-status
reviewed
Jun 23, 2022
Comment on lines
+938
to
+939
| log "After ALTAIR_FORK_EPOCH" | ||
|
|
There was a problem hiding this comment.
There is already a log one line below this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored by @hmel