-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the starting geth nodes as part of local testnet #3706
Conversation
"mixHash":"0x0000000000000000000000000000000000000000000000000000000000000000", | ||
"coinbase":"0x0000000000000000000000000000000000000000", | ||
"alloc":{ | ||
"0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b":{"balance":"0x6d6172697573766477000000"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the private keys for these accounts are provided as well in the repo, so the developers can execute transactions with them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for next phase with accounts+transactions I will add them
@@ -0,0 +1,44 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this file is somewhat inconsistent - shouldn't it be nimbus_el_genesis.json
? Also, do we actually need this file, considering that it's exactly the same as the geth_genesis.json
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was called genesis.json, but @tersec suggested it's too vague, so I changed it. This way it's easier to make changes to one without affecting the other.
|
||
if [[ "${RUN_NIMBUS}" == "1" ]]; then | ||
for NUM_NODE in $(seq 0 $(( NUM_NODES - 1 ))); do | ||
for PORT in $(( NUM_NODE * NIMBUSEL_PORT_OFFSET + NIMBUSEL_NET_BASE_PORT )) $(( NUM_NODE * NIMBUSEL_PORT_OFFSET + NIMBUSEL_HTTP_BASE_PORT )) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplicated block of code here looks like a function that kills all processing listening on ports within a given interval. You can define and reuse such a function for both Geth and Nimbus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did some copy-pasta there and forgot to change it. Will fix
e99f51f
to
1d4a140
Compare
Rebased on top of unstable here: |
so this can be closed? |
Adds
--run-geth parameter to launch_local_testnet.sh script, which launches a number of geth nodes and connects them to each other before starting the nimbus-eth2 client.Added missing --light-clients options to parsed parameters.