Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the starting geth nodes as part of local testnet #3706

Closed
wants to merge 5 commits into from

Conversation

hmel
Copy link
Contributor

@hmel hmel commented Jun 5, 2022

Adds --run-geth parameter to launch_local_testnet.sh script, which launches a number of geth nodes and connects them to each other before starting the nimbus-eth2 client.
Added missing --light-clients options to parsed parameters.

@hmel hmel requested review from zah and tersec June 5, 2022 18:03
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Unit Test Results

     12 files     836 suites   1h 13m 25s ⏱️
1 707 tests 1 655 ✔️   52 💤 0
9 882 runs  9 754 ✔️ 128 💤 0

Results for commit 9d0be3d.

♻️ This comment has been updated with latest results.

scripts/genesis.json Outdated Show resolved Hide resolved
@hmel hmel requested a review from tersec June 6, 2022 13:18
scripts/geth_genesis.json Outdated Show resolved Hide resolved
scripts/launch_local_testnet.sh Outdated Show resolved Hide resolved
"mixHash":"0x0000000000000000000000000000000000000000000000000000000000000000",
"coinbase":"0x0000000000000000000000000000000000000000",
"alloc":{
"0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b":{"balance":"0x6d6172697573766477000000"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the private keys for these accounts are provided as well in the repo, so the developers can execute transactions with them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for next phase with accounts+transactions I will add them

@@ -0,0 +1,44 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of this file is somewhat inconsistent - shouldn't it be nimbus_el_genesis.json? Also, do we actually need this file, considering that it's exactly the same as the geth_genesis.json file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was called genesis.json, but @tersec suggested it's too vague, so I changed it. This way it's easier to make changes to one without affecting the other.


if [[ "${RUN_NIMBUS}" == "1" ]]; then
for NUM_NODE in $(seq 0 $(( NUM_NODES - 1 ))); do
for PORT in $(( NUM_NODE * NIMBUSEL_PORT_OFFSET + NIMBUSEL_NET_BASE_PORT )) $(( NUM_NODE * NIMBUSEL_PORT_OFFSET + NIMBUSEL_HTTP_BASE_PORT )) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicated block of code here looks like a function that kills all processing listening on ports within a given interval. You can define and reuse such a function for both Geth and Nimbus

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did some copy-pasta there and forgot to change it. Will fix

@zah
Copy link
Member

zah commented Jun 22, 2022

Rebased on top of unstable here:

#3790

@arnetheduck
Copy link
Member

so this can be closed?

@zah zah closed this Jun 28, 2022
@hmel hmel deleted the face/kiln-dev-auth branch June 29, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants