Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pivot before cyclic imports force big file changes #128

Closed
wants to merge 6 commits into from
Closed

Merge pivot before cyclic imports force big file changes #128

wants to merge 6 commits into from

Conversation

wisnesky
Copy link
Contributor

@wisnesky wisnesky commented Dec 3, 2018

No description provided.

marcosh
marcosh reviewed Dec 7, 2018
View reviewed changes
examples/Petri.aql
foreign_keys
place : Input -> Place
trans : Input -> Trans
place : Output -> Place
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the parses does not allow duplicate bingings. If I try to run this example with stack exec aql-exe I get the following error message Eval Error in Net: Duplicate binding: "trans"

src/Language/Instance.hs Show resolved Hide resolved
src/Language/Instance.hs Show resolved Hide resolved
src/Language/Instance.hs Outdated Show resolved Hide resolved
src/Language/Instance.hs Outdated Show resolved Hide resolved
src/Language/Instance.hs Outdated Show resolved Hide resolved
src/Language/Parser/Instance.hs Outdated Show resolved Hide resolved
This was referenced Jul 31, 2019
Closed
Open
Merged
@epost
Copy link
Member

epost commented Aug 5, 2019

Thanks Ryan! I fixed the merge conflicts that have arisen since you contributed this in #147, so closing this.

@epost epost closed this Aug 5, 2019
epost added a commit that referenced this pull request Aug 7, 2019
@epost
Address @marcosh's comments from #128. #146
7da0cb7
epost added a commit that referenced this pull request Aug 7, 2019
@epost
Add pivot feature. #146 (#147)
b7b6e91 
* more work on pivot (Ryan)

* pivot is essentially done but finishing it causes cyclic imports

* code formatting and styling #38

* Rename AQL stuff in tests to CQL. #146

* Address @marcosh's comments from #128. #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosh marcosh marcosh left review comments

@epost epost Awaiting requested review from epost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wisnesky @epost @marcosh