-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code formatting and styling #38
Comments
Yesh! Glad you asked. This is work in progress but it does tackle some important points: https://hackmd.io/U8vrBv94TqK413F0GIEAfg. We probably also want to use an What would be a good place to hook in your suggested linting? |
I'll take a look at I'm using Otherwise we could setup something which formats the code as soon as it is pushed, so we are sure that in code review everything is written nicely |
Yeah that seems like a good idea for now. I was thinking we could validate it during the automated build, but not sure how easy that is, since our The
|
There are also some tab warnings, |
oh the tab issue seems to be fixed already in master: |
yeah I just merged Marco's commit. |
|
fix styling according to stack --pedantic #38
Based on our rocketchat discussions of last night and before, we're investigating code formatters, and the extent to which they can help us produce readable code in the spirit of the stuff discussed above. |
Is anyone besides me using a Mac? Getting ‘stack build’ to recognize ‘—pedantic’ would remove the cycle where I have to commit and push to read error messages from Travis CI.
… On Oct 23, 2018, at 8:12 AM, Erik Post ***@***.***> wrote:
Based on our rocketchat discussions of last night and before, we're investigating code formatters, and the extent to which they can help us produce readable code in the spirit of the stuff discussed above.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
To avoid code written in too different styles, I would encourage the use of
hlint
andhindent
and also compiling withstack --pedantic
.If you have any other styling rule you'd like to be followed, that would be nice to share
**Update 2018-05-31 by @epost and @marcosh **: https://www.tweag.io/posts/2019-05-27-ormolu.html and https://github.com/ennocramer/floskell
The text was updated successfully, but these errors were encountered: