-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the test suite connectivity-agnostic. #12095
Make the test suite connectivity-agnostic. #12095
Conversation
The Windows test output for this change appears to have uncovered an unrelated problem: handling
My best guess is around this area of code (it has quite a large sphinx/sphinx/transforms/post_transforms/images.py Lines 57 to 113 in 98d0cc8
These lines initially seem like a possibility: sphinx/sphinx/transforms/post_transforms/images.py Lines 70 to 71 in 98d0cc8
|
…ess." This reverts commit fb23eff.
8e38511
to
9ca2670
Compare
…e-12094/test-suite-connectivity-agnostic
See #12100 (comment) for more details about the cause of this. In short: the colon character, as used to indicate the network port number within URIs, is not considered a valid character within the components of directory paths on Windows, and therefore remote image URIs such as this one were caused a problem for the existing |
…port number segments." This reverts commit 9ca2670.
…e-12094/test-suite-connectivity-agnostic Conflicts: sphinx/transforms/post_transforms/images.py
…sphinx-doc#12100 fix." This reverts commit 04d7c9d.
No further changes planned. Please note that this branch depends upon / includes #12253. |
…vity-agnostic # Conflicts: # sphinx/transforms/post_transforms/images.py
Thank you! |
Feature or Bugfix
Purpose
Detail
epubcheck
to fail when checking anepub
file that contains remote references (because the image couldn't be retrieved during the Sphinx build).Relates