-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: network state (online/offline) affects epubcheck unit test outcome. #12094
Labels
Comments
Output from
|
This was referenced Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
The
test_run_epubcheck
unit test case passes as expected when:epubcheck[.jar]
program is found.DO_EPUBCHECK
environment variable is set (the value does not matter).test-root/images.txt
file.(note: we do enable
DO_EPUBCHECK
in our continous integration in thelatex
workflow -- andepubcheck
is installed into the relevantsphinx-ci
container image)There are a few quirks here: I think that the test behaving differently offline isn't desirable though (or to phrase it another way: connectivity shouldn't be a requirement for most dependable software to test/build, because it's hard to predict when/where it will be rebuilt).
How to Reproduce
Ensure that
epubcheck
and the local development and test dependencies forsphinx
are installed, and then disable network connectivity on the unit test host.From the
sphinx.git
checkout directory:Environment Information
Sphinx extensions
Additional context
No response
The text was updated successfully, but these errors were encountered: