Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] skip tests that need remote content if host is offline #12091

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Mar 14, 2024

Don't forget people who work offline!

@picnixz picnixz merged commit 98d0cc8 into sphinx-doc:master Mar 14, 2024
22 checks passed
@picnixz picnixz deleted the tests/offlineness branch March 14, 2024 14:33
@jayaddison
Copy link
Contributor

@picnixz test_run_epubcheck unexpectedly fails offline too, and could be worth adding to the list here.

The reason for that is quite obscure: it seems that we write a slightly different output .epub file containing 'remote references' if we're unable to download the content locally during the build. When epubcheck checks the (different) resulting output, it isn't happy about those remote references and complains.

I don't know of a way to run GitHub Actions workflows in a way that prevents them from making outbound network connectivity, but such a thing might exist.

@picnixz
Copy link
Member Author

picnixz commented Mar 14, 2024

I actually don't run it because I don't have epubcheck.. so... I never saw the error.

@jayaddison
Copy link
Contributor

Yep, neither had I previously - I'm trying to make the tests behave more similarly offline and online after seeing this change. In particular: replacing some of the remote image links with content served by our good friend localhost:7777.

When I did that, I tried to get as many skipped tests to run as possible (in case I'd missed any other cases), and found that test_run_epubcheck failed.. but only when offline! Weird.

@jayaddison
Copy link
Contributor

Filed the details as #12094 - there are some easy-ish small improvements, and it may be low priority, but I'll try to suggest one or two adjustments soon.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants