Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-commit): add a pre-commit job to CI #321

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Nov 24, 2023

Description & motivation

This PR enforces the coding & repository standards we have defined via the pre-commit file.

Changes:

  • adds a job to run pre-commit to circleci
  • resolves an error with broken pre-commit packages by bumping pre-commit package versions using pre-commit autoupdate

To-do before merge:

  • Fix all the linting issues this PR uncovered
    • Replicate locally
      1. Check out this PR's branch
      2. Install pre-commit (https://pre-commit.com/)
      3. Run pre-commit run --all-files

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@gjedlicska gjedlicska marked this pull request as ready for review November 27, 2023 13:29
@gjedlicska gjedlicska merged commit 4e96aad into main Nov 27, 2023
3 checks passed
@gjedlicska gjedlicska deleted the iain/circleci-pre-commit branch November 27, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants