feat(client): configurable certificate verification #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
commented
Nov 24, 2023
src/specklepy/core/api/client.py
Outdated
|
|
||
| def __init__(self, host: str = DEFAULT_HOST, use_ssl: bool = USE_SSL) -> None: | ||
| def __init__(self, host: str = DEFAULT_HOST, use_ssl: bool = USE_SSL, verify_certificate: bool = VERIFY_CERTIFICATE) -> None: |
There was a problem hiding this comment.
@gjedlicska - should this line be wrapped?
As a side quest, there should probably be a linter running in CI that would catch long lines like this.
There was a problem hiding this comment.
I completed the side-quest, but it threw up a lot of python linting issues: #321
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 89 89
Lines 5335 5337 +2
=======================================
+ Hits 4821 4823 +2
Misses 514 514 ☔ View full report in Codecov by Sentry. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Currently the client always validates the certificate. This is secure behaviour and should continue to be the default.
In certain conditions, for example when using specklepy with a server in a test environment, the server may not be able to present a valid certificate.
In these conditions it is helpful to be able to disable certificate verification.
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References