Create new Setting Command #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a test is failing, but looking great already! |
Yeah ... I tried looking into that. I couldn't quite figure out why it wasn't working. |
Shoot ... I didn't realise it was my test that was failing.😬 Let me fix it really quick. |
|
@rubenvanassche The test should pass now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, I'm too lazy to create a new class whenever I need to add a new group of settings😂😂. This feature was first introduced by @egyjs in #126. But because of inactivity, it was closed without being merged.
This PR adds a new
make:settingcommand, that is functional and its test included.