The MakeSettingsClass command speeds up the process #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvanassche
requested changes
Apr 6, 2022
| protected function getStub() | ||
| { | ||
| return __DIR__.'/stubs/settingClass.stub'; // todo: add stubs to package! | ||
|
|
|
|
||
| protected function buildClass($name): array|string | ||
| { | ||
| $class = parent::buildClass($name); // todo: uncomment after stubs added to package! |
| { | ||
| return $rootNamespace.'\Settings'; | ||
| } | ||
|
|
| } | ||
|
|
||
| return $class; | ||
| } |
|
|
||
| use Illuminate\Console\GeneratorCommand; | ||
|
|
||
|
|
| $class = parent::buildClass($name); // todo: uncomment after stubs added to package! | ||
|
|
||
| if ($this->option('group')) { | ||
| $class = str_replace(['DummyView','{{ group }}'], $this->option('group'), $class); |
There was a problem hiding this comment.
What is the use of DummyView here?
Could we dynamically deduce group from the name? Name probably always will be something like CreateBlogPostSettings if we take BlogPost from that we can make it snake case so it would look like blog_post. Off course we would keep the group command parameter to manually set the group.
Comment on lines
+9
to
+14
| /** | ||
| * The app name. | ||
| * | ||
| * @return string | ||
| */ | ||
| // protected $appName = 'Laravel Settings'; |
There was a problem hiding this comment.
Let's not add this to an empty Settings class
|
Closing this due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.