Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transverb: non-thread-safe use of RandomGenerator #45

Closed
sophiapoirier opened this issue Jul 19, 2021 · 0 comments
Closed

Transverb: non-thread-safe use of RandomGenerator #45

sophiapoirier opened this issue Jul 19, 2021 · 0 comments
Assignees
@sophiapoirier

Comments

@sophiapoirier
Copy link
Owner

Following #43, Transverb is still randomizing parameters (now via dfx::math::RandomGenerator) in a non-thread-safe fashion since the randomization can be triggered from the main (GUI) thread or MIDI event thread.
@sophiapoirier sophiapoirier mentioned this issue Jul 19, 2021
Closed
sophiapoirier added a commit that referenced this issue Jul 21, 2021
@sophiapoirier
move responsibility for parameter randomization from DfxParam to DfxP…
228f45b 
…lugin, since it owns the random engine, and tighten the scope of its critical section (optimizes #45)
@sophiapoirier sophiapoirier self-assigned this Aug 28, 2021
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophiapoirier sophiapoirier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sophiapoirier