Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-thread-safe and deprecated use of CRT rand #43

Closed
sophiapoirier opened this issue Jul 17, 2021 · 1 comment
Closed

non-thread-safe and deprecated use of CRT rand #43

sophiapoirier opened this issue Jul 17, 2021 · 1 comment
Assignees
@sophiapoirier

Comments

@sophiapoirier
Copy link
Owner

The C runtime library function rand is deprecated (C++ replacements live in the STL header random), but more importantly we use it in non-thread-safe fashion in various places in our effects (e.g. randomize parameter value actions can be executed from several threads, like main or MIDI event threads, but the random generator has global state that mutates when generating the next value and is not thread-safe).
@sophiapoirier sophiapoirier self-assigned this Jul 17, 2021
@sophiapoirier sophiapoirier mentioned this issue Jul 19, 2021
Closed
@sophiapoirier
Copy link
Owner Author

I've decided to break out the thread-safety issue that is specific to Transverb in #45

sophiapoirier added a commit that referenced this issue Jul 20, 2021
@sophiapoirier
break out dfx::math::RandomEngine from RandomGenerator to allow bette…
84e7a0e 
…r reuse of engine instances and thereby greatly reduce memory usage (optimizes #43)
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophiapoirier sophiapoirier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sophiapoirier