Remove attribute translations for associations #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we sure we want to switch it to |
|
In the error message it's that text that is rendered now but the text that is displayed on the page is |
|
okay, thats fair to me than, thanks. I don't super care about casing myself but was wondering why the change. 👍 |
Murph33
force-pushed
the
remove_association_translations
branch
3 times, most recently
from
e6eb4cf
to
17cfb7a
Compare
Example. Instead of having country_id having a translation under the address model attributes of country just use Spree::Country.model_name.human.
Murph33
force-pushed
the
remove_association_translations
branch
from
17cfb7a
to
20d7e96
Compare
|
👍 |
jhawthorn
added a commit
that referenced
this pull request
Feb 18, 2016
Remove attribute translations for associations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example instead of having
just explicitly use
Spree::Country.model_name.humanon the form label.This PR will correct previous changes made to this preferred method as discussed in #735 and pointed out by #856 (comment)