Improve I18n in variant views #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murph33
force-pushed
the
improve_i18n_variant
branch
2 times, most recently
from
048c808
to
a4f85d6
Compare
|
👍 |
| <%= f.text_field :cost_price, :value => number_to_currency(@variant.cost_price, :unit => ''), :class => 'fullwidth' %> | ||
| </div> | ||
|
|
||
| <div class="field" data-hook="tax_category"> | ||
| <%= f.label :tax_category_id, Spree.t(:tax_category) %> | ||
| <%= f.label :tax_category_id %> |
There was a problem hiding this comment.
Better use Spree::TaxCategory.model_name.human here
Use model name and model attribute translation.
Murph33
force-pushed
the
improve_i18n_variant
branch
from
a4f85d6
to
cc282e2
Compare
jhawthorn
added a commit
that referenced
this pull request
Feb 15, 2016
Improve I18n in variant views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use model name and model attribute translation.
I had considered changing the form to not use the
label-blockclass so that then I could use model attribute translation on thetrack_inventorycheckbox but decided against it as it changed the spacing of all the labels too much.This is part of an ongoing effort to improve I18n usage as discussed in #735.