Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.3] Bundle solidus_admin >= 0.2 in Solidus installer #5608

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[v4.3] Bundle solidus_admin >= 0.2 in Solidus installer #5608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Bundle solidus_admin >= 0.2 in Solidus installer 
Currently, running `rails g solidus:install` on a new rails app
bundles `solidus_admin` with version `0.0.0`, which is empty.

This leads to inconsistencies, the first one being the dedicated
`solidus_admin` generator is not found and consequently cannot be
run.

(cherry picked from commit 6060072)
  • Loading branch information
@spaghetticode
spaghetticode committed Jan 22, 2024
commit 136fb455c6d1dbbe6eec4443f10abd24fce2cb49
2 changes: 1 addition & 1 deletion core/lib/generators/solidus/install/install_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def install_solidus_admin
return unless options[:admin_preview]

say_status :installing, "SolidusAdmin", :blue
bundle_command 'add solidus_admin'
bundle_command 'add solidus_admin -v ">= 0.2"'
generate 'solidus_admin:install'
end

Expand Down