Skip to content

Commit

Permalink
Bundle solidus_admin >= 0.2 in Solidus installer
Browse files Browse the repository at this point in the history
Currently, running `rails g solidus:install` on a new rails app
bundles `solidus_admin` with version `0.0.0`, which is empty.

This leads to inconsistencies, the first one being the dedicated
`solidus_admin` generator is not found and consequently cannot be
run.
  • Loading branch information
spaghetticode committed Jan 19, 2024
1 parent 6ef5c78 commit 6060072
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/lib/generators/solidus/install/install_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def install_solidus_admin
return unless options[:admin_preview]

say_status :installing, "SolidusAdmin", :blue
bundle_command 'add solidus_admin'
bundle_command 'add solidus_admin -v ">= 0.2"'

Check warning on line 182 in core/lib/generators/solidus/install/install_generator.rb

View check run for this annotation

Codecov / codecov/patch

core/lib/generators/solidus/install/install_generator.rb#L182

Added line #L182 was not covered by tests
generate 'solidus_admin:install'
end

Expand Down

0 comments on commit 6060072

Please sign in to comment.