Deprecate Spree::NamedType Concern
#5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
This module was a pretend shared behavior while the inlcuding classes were not related. Eventually we'll replace some of the default scopes with regular sorting scopes since default scopes often cause issues. Co-Authored-By: Rainer Dema <[email protected]>
elia
force-pushed
the
elia+rainer/deprecate-named-type
branch
from
20535a7
to
af0c7d3
Compare
kennyadsl
reviewed
Dec 6, 2023
| @@ -2,7 +2,10 @@ | |||
|
|
|||
| module Spree | |||
| class RefundReason < Spree::Base | |||
| include Spree::NamedType | |||
| scope :active, -> { where(active: true) } | |||
| default_scope -> { order(arel_table[:name].lower) } | |||
There was a problem hiding this comment.
Is there any value in having this "metaprogramming" now?
There was a problem hiding this comment.
Yes, default scopes are troublemakers and eventually we'd like to migrate them to regular scopes (e.g. scope :order_by_name …) so they don't get in the way with other things (joins, batch loading, …). While checking where the default scopes were defined we thought that this "concern" was not actually shared behavior but would be better off as local model features.
I hope I got the question right, otherwise let me know 🙏
rainerdema
approved these changes
Dec 19, 2023
kennyadsl
changed the title
Spree::NamedTypeSpree::NamedType Concern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This module was a pretend shared behavior while the inlcuding classes were not related.
Eventually we'll replace some of the default scopes with regular sorting scopes since default scopes often cause issues.
Ref: b2d4a7c
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: