Deprecate Spree::NamedType

This module was a pretend shared behavior while the inlcuding classes
were not related.

Eventually we'll replace some of the default scopes with regular sorting
scopes since default scopes often cause issues.

core/app/models/concerns/spree/named_type.rb

@@ -5,6 +5,8 @@ module NamedType
  extend ActiveSupport::Concern
 
  included do
+ Spree.deprecator.warn "Spree::NamedType is deprecated. Please set scopes and validations locally instead.", caller
+
  scope :active, -> { where(active: true) }
  default_scope -> { order(arel_table[:name].lower) }
 

core/app/models/spree/refund_reason.rb

@@ -2,7 +2,10 @@
 
 module Spree
  class RefundReason < Spree::Base
- include Spree::NamedType
+ scope :active, -> { where(active: true) }
+ default_scope -> { order(arel_table[:name].lower) }
+
+ validates :name, presence: true, uniqueness: { case_sensitive: false, allow_blank: true }
 
  RETURN_PROCESSING_REASON = 'Return processing'
 

core/app/models/spree/reimbursement_type.rb

@@ -2,7 +2,10 @@
 
 module Spree
  class ReimbursementType < Spree::Base
- include Spree::NamedType
+ scope :active, -> { where(active: true) }
+ default_scope -> { order(arel_table[:name].lower) }
+
+ validates :name, presence: true, uniqueness: { case_sensitive: false, allow_blank: true }
 
  ORIGINAL = 'original'
 

core/app/models/spree/return_reason.rb

@@ -2,7 +2,10 @@
 
 module Spree
  class ReturnReason < Spree::Base
- include Spree::NamedType
+ scope :active, -> { where(active: true) }
+ default_scope -> { order(arel_table[:name].lower) }
+
+ validates :name, presence: true, uniqueness: { case_sensitive: false, allow_blank: true }
 
  has_many :return_authorizations
 

core/app/models/spree/store_credit_reason.rb

@@ -1,7 +1,10 @@
 # frozen_string_literal: true
 
 class Spree::StoreCreditReason < Spree::Base
- include Spree::NamedType
+ scope :active, -> { where(active: true) }
+ default_scope -> { order(arel_table[:name].lower) }
+
+ validates :name, presence: true, uniqueness: { case_sensitive: false, allow_blank: true }
 
  has_many :store_credit_events, inverse_of: :store_credit_reason
 end