Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Add scopes and controller helpers for ui/table #5516

Merged
merged 14 commits into from
Nov 24, 2023
Merged

[admin] Add scopes and controller helpers for ui/table #5516

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
13ab92a
Don't add filter hidden inputs if not required in `ui/table`
elia Nov 23, 2023
12298c4
Don't change the cursor for disabled button
elia Nov 24, 2023
d7191a2
Fix the store url to always have an HTTP(S) protocol defined
elia Nov 24, 2023
6def880
Reorganize `ui/table` intializer
elia Nov 24, 2023
c09369a
Let the first render of `ui/table` already hide toolbars based on the…
elia Nov 24, 2023
bfae492
Reset `ui/table` filters when exiting clicking on "cancel" from searc…
elia Nov 24, 2023
cddacff
Extract common search patterns to a controller helper
elia Nov 24, 2023
1406dad
Add support for scopes to `ui/table`
elia Nov 24, 2023
c7f7af5
Add a state column to `orders/index`
elia Nov 24, 2023
9ad6bd6
Only hide `ui/table` cells overflow horizontally when wrapped
elia Nov 24, 2023
00d145e
Allow the `ui/tab` component to pick an arbitrary tag
elia Nov 24, 2023
ff3c195
Adjust the `ui/tab` colors so when disabled by a form submission they…
elia Nov 24, 2023
34faee9
Refactor `ui/table` to use the internal objects instead of proxy ivars
elia Nov 24, 2023
73b1ded
Use turbo-permanent in `ui/table` for navigating out of search mode
elia Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't add filter hidden inputs if not required in ui/table 
This helps keeping the query URL short.

Co-Authored-By: Rainer Dema <[email protected]>
  • Loading branch information
@elia @rainerdema
elia and rainerdema committed Nov 24, 2023
commit 13ab92ac6e363b8c8c878f910852b9df6f1843b9
2 changes: 1 addition & 1 deletion admin/app/components/solidus_admin/ui/table/ransack_filter/component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
checked: selection.checked,
size: :s,
form: @form,
"data-action": "#{stimulus_id}#search #{stimulus_id}#sortCheckboxes",
"data-action": "#{stimulus_id}#search #{stimulus_id}#sortCheckboxes #{stimulus_id}#updateHiddenInputs",
"data-#{stimulus_id}-target": "checkbox"
) %>

Expand Down
10 changes: 10 additions & 0 deletions admin/app/components/solidus_admin/ui/table/ransack_filter/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export default class extends Controller {
useDebounce(this, { wait: 50 })
useClickOutside(this)
this.init()
this.updateHiddenInputs()
}

clickOutside(event) {
Expand Down Expand Up @@ -44,6 +45,15 @@ export default class extends Controller {
this.highlightFilter()
}

updateHiddenInputs() {
this.checkboxTargets.forEach((checkbox) => {
const hiddenElements = checkbox.parentElement.querySelectorAll("input[type='hidden']")
checkbox.checked
? hiddenElements.forEach(e => e.removeAttribute("disabled"))
: hiddenElements.forEach(e => e.setAttribute("disabled", true))
})
}

sortCheckboxes() {
const checkboxes = this.checkboxTargets

Expand Down