Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Add scopes and controller helpers for ui/table #5516

Merged
merged 14 commits into from
Nov 24, 2023
Merged

[admin] Add scopes and controller helpers for ui/table #5516

merged 14 commits into from
Nov 24, 2023

Commits on Nov 24, 2023

  1. Don't add filter hidden inputs if not required in ui/table 

    This helps keeping the query URL short.

Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    13ab92a View commit details
    Browse the repository at this point in the history

  2. Don't change the cursor for disabled button 

    Using not-allowed can be confusing when a button is disabled temporarily
while submitting a form.

Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    12298c4 View commit details
    Browse the repository at this point in the history

  3. Fix the store url to always have an HTTP(S) protocol defined 

    This helps not interpreting a domain as a relative path.
Also points the logo to the root of the admin.

Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    d7191a2 View commit details
    Browse the repository at this point in the history

  4. Reorganize ui/table intializer 

    The list of kwargs and the number of objects was very high, after this
we can delegate some of the logic to supporting classes.

Grouping by data and search kwargs might also help in future splitting
or extraction of subcomponents.

Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    6def880 View commit details
    Browse the repository at this point in the history

  5. Let the first render of ui/table already hide toolbars based on the… 

    … mode

Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    c09369a View commit details
    Browse the repository at this point in the history

  6. Reset ui/table filters when exiting clicking on "cancel" from searc… 

    …h mode

Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    bfae492 View commit details
    Browse the repository at this point in the history

  7. Extract common search patterns to a controller helper 

    This will be also the home for the upcoming scope support.

Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    cddacff View commit details
    Browse the repository at this point in the history

  8. Add support for scopes to ui/table 

    Scopes are alternative pools of record on which further filtering
can be performed.

Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    1406dad View commit details
    Browse the repository at this point in the history

  9. Add a state column to orders/index 

    Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    c7f7af5 View commit details
    Browse the repository at this point in the history

  10. Only hide ui/table cells overflow horizontally when wrapped

    @elia
    elia committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    9ad6bd6 View commit details
    Browse the repository at this point in the history

  11. Allow the ui/tab component to pick an arbitrary tag

    @elia
    elia committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    00d145e View commit details
    Browse the repository at this point in the history

  12. Adjust the ui/tab colors so when disabled by a form submission they… 

    … won't flash
    @elia
    elia committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    ff3c195 View commit details
    Browse the repository at this point in the history

  13. Refactor ui/table to use the internal objects instead of proxy ivars

    @elia
    elia committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    34faee9 View commit details
    Browse the repository at this point in the history

  14. Use turbo-permanent in ui/table for navigating out of search mode 

    Co-Authored-By: Rainer Dema <[email protected]>
    @elia @rainerdema
    elia and rainerdema committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    73b1ded View commit details
    Browse the repository at this point in the history