[Admin] Fix ui/table/toolbar & restore clearSearch & Streamline feedback rendering
#5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerdema
changed the title
ui/table/toolbar component params & restore clearSearchui/table/toolbar & restore clearSearch & Streamline feedback rendering
elia
approved these changes
Oct 24, 2023
admin/app/components/solidus_admin/ui/table/toolbar/component.rb
Outdated
Show resolved
Hide resolved
Updated the `SolidusAdmin::UI::Table::Toolbar::Component` to accept and render additional parameters.
The `clearSearch` function was previously removed, causing search clearing issues. This commit re-introduces the function, restoring its functionality.
Eliminated an unnecessary double rendering of the feedback component in both the Orders and Products tables. This change leverages the `page_header_actions` helper, aligning with the updates in solidusio#5445.
rainerdema
force-pushed
the
rainerd/fix-toolbar-component-params
branch
from
3f18f81
to
44c41c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses three fixes:
ui/table/toolbarcomponent to support additional parameters correctly.clearSearchfunction, ensuring the search functionality works as expected.feedbackcomponent in the Orders and Products tables, leveraging thepage_header_actionshelper: SolidusAdmin: Extract page layout helpers #5445.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: