SolidusAdmin: Extract page layout helpers #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/admin/page-helpers
branch
from
f18cf56
to
510878d
Compare
Codecov Report
@@ Coverage Diff @@
## main #5445 +/- ##
==========================================
+ Coverage 88.89% 88.91% +0.02%
==========================================
Files 612 614 +2
Lines 14800 14827 +27
==========================================
+ Hits 13156 13183 +27
Misses 1644 1644
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
approved these changes
Oct 19, 2023
rainerdema
added a commit
to nebulab/solidus
that referenced
this pull request
Oct 23, 2023
Eliminated an unnecessary double rendering of the feedback component in both the Orders and Products tables. This change leverages the `page_header_actions` helper, aligning with the updates in solidusio#5445.
3 tasks
rainerdema
added a commit
to nebulab/solidus
that referenced
this pull request
Oct 24, 2023
Eliminated an unnecessary double rendering of the feedback component in both the Orders and Products tables. This change leverages the `page_header_actions` helper, aligning with the updates in solidusio#5445.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extract some helpers that can be used to build page layouts, this is the first step in sharing this code, we're looking toward a better solution for the future (e.g. one or multiple components, or prebuilt TW classes) but it's early to tell which will be the best approach.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: