Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Active Storage in Dummy App for extensions #3969

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Add Active Storage in Dummy App for extensions #3969

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fffd555
Use Active Storage adapters as default configuration value
kennyadsl Mar 2, 2021
db7ff8d
Configure Active Storage on dummy apps for extensions
kennyadsl Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use Active Storage adapters as default configuration value 
This is important because extensions that are testing against Solidus
3.0 does not have the default adapter set to Active Storage; extensions'
dummy app is not executing the solidus:install command and won't have
the intializer copied over to configure the app.
  • Loading branch information
@kennyadsl
kennyadsl committed Mar 8, 2021
commit fffd555faef98e146ad1bc7a345de9c51c705611
12 changes: 6 additions & 6 deletions core/lib/spree/app_configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,23 +437,23 @@ def payment_canceller

# Allows switching attachment library for Image
#
# `Spree::Image::PaperclipAttachment`
# is the default and provides the classic Paperclip implementation.
# `Spree::Image::ActiveStorageAttachment`
# is the default and provides the Active Storage implementation.
#
# @!attribute [rw] image_attachment_module
# @return [Module] a module that can be included into Spree::Image to allow attachments
# Enumerable of images adhering to the present_image_class interface
class_name_attribute :image_attachment_module, default: 'Spree::Image::PaperclipAttachment'
class_name_attribute :image_attachment_module, default: 'Spree::Image::ActiveStorageAttachment'

# Allows switching attachment library for Taxon
#
# `Spree::Taxon::PaperclipAttachment`
# is the default and provides the classic Paperclip implementation.
# `Spree::Taxon::ActiveStorageAttachment`
# is the default and provides the Active Storage implementation.
#
# @!attribute [rw] taxon_attachment_module
# @return [Module] a module that can be included into Spree::Taxon to allow attachments
# Enumerable of taxons adhering to the present_taxon_class interface
class_name_attribute :taxon_attachment_module, default: 'Spree::Taxon::PaperclipAttachment'
class_name_attribute :taxon_attachment_module, default: 'Spree::Taxon::ActiveStorageAttachment'

# Allows providing your own class instance for generating order numbers.
#
Expand Down