Add Active Storage in Dummy App for extensions #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
added
type:bug
kennyadsl
force-pushed
the
kennyadsl/add-activestorage-dummy-extensions
branch
from
bdb8ae9
to
3a2d11c
Compare
kennyadsl
changed the title
kennyadsl
force-pushed
the
kennyadsl/add-activestorage-dummy-extensions
branch
from
3a2d11c
to
0541c65
Compare
aldesantis
approved these changes
Mar 5, 2021
This is important because extensions that are testing against Solidus 3.0 does not have the default adapter set to Active Storage; extensions' dummy app is not executing the solidus:install command and won't have the intializer copied over to configure the app.
Copying the .yml configuration file into config/storage/test.yml will automatically configure Active Storage in that env [1]. The configuration key needs to be the same of the service set into config/environments/test.rb. When testing extensions against old versions of Solidus, it will not use Active Storage so, it should not be harmful to have it configured anyway. [1]: https://github.com/rails/rails/blob/66b861f24cd8ca34b726f77b46f6b25b21f0b972/activestorage/lib/active_storage/engine.rb#L115-L132
kennyadsl
force-pushed
the
kennyadsl/add-activestorage-dummy-extensions
branch
from
0541c65
to
db7ff8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sure Active Storage is properly configured when we are generating dummy apps for extensions. This is done in the extension root with:
Ref #3967
I tested this PR with solidus_starter_frontend that uses Active Storage in some system specs. See solidusio/solidus_starter_frontend#145
No need to backport this one, it will only affect extensions testing against Solidus 3.0, which will default to using Active Storage.
Needs #3970 to be merged first.