Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display billing address to left of shipping address #3773

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Display billing address to left of shipping address #3773

merged 1 commit into from
Sep 30, 2020

Conversation

brchristian
Copy link
Contributor

@brchristian brchristian commented Sep 24, 2020 •
edited
Loading

This makes the backend views consistent with the frontend.

Fixes #3771.

Old view:

Screen Shot 2020-09-24 at 10 09 16 AM

New view:

Screen Shot 2020-09-24 at 10 09 35 AM

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@brchristian
Display billing address to left of shipping address
5ea24e9 
This makes the backend views consistent with the frontend.
Fixes solidusio#3771
@brchristian brchristian mentioned this pull request Sep 24, 2020
Closed
kennyadsl
kennyadsl approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

aldesantis
aldesantis approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@aldesantis aldesantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit d7fa395 into solidusio:master Sep 30, 2020
@brchristian brchristian deleted the billing_on_left_of_shipping branch September 30, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@aldesantis aldesantis aldesantis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shipping/Billing addresses appear inconsistent on frontend vs. backend
3 participants
@brchristian @kennyadsl @aldesantis