Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shipping/Billing addresses appear inconsistent on frontend vs. backend #3771

Closed
brchristian opened this issue Sep 24, 2020 · 4 comments · Fixed by #3773
Closed

Shipping/Billing addresses appear inconsistent on frontend vs. backend #3771

brchristian opened this issue Sep 24, 2020 · 4 comments · Fixed by #3773

Comments

@brchristian
Copy link
Contributor

brchristian commented Sep 24, 2020 •
edited
Loading

Solidus Version:
2.10

To Reproduce

  1. On frontend, begin checkout and get to Address step. Notice that shipping is on the right:

Screen Shot 2020-09-23 at 5 56 57 PM

  1. On backend, go to Order > Customer. Notice that shipping is on the left:

Screen Shot 2020-09-23 at 5 59 09 PM

Current behavior
The order is different.

Expected behavior
The order is the same

Steps to fix
I would be very happy to prepare a PR for this. The question is, which order is the correct one?
@aldesantis
Copy link
Member

@brchristian since the Shipping Address column has the "Use Billing Address" checkbox, I think the correct order would be Billing and then Shipping, like in the frontend. @solidusio/core-team do you have any opinions here?

@tvdeyen
Copy link
Member

tvdeyen commented Sep 24, 2020

@aldesantis @brchristian I agree with Billing, then Shipping

@kennyadsl
Copy link
Member

kennyadsl commented Sep 24, 2020 •
edited
Loading

I also agree to make them consistent and Billing should come first as in the frontend.

brchristian added a commit to brchristian/solidus that referenced this issue Sep 24, 2020
@brchristian
Display billing address to left of shipping address
5ea24e9 
This makes the backend views consistent with the frontend.
Fixes solidusio#3771
@brchristian brchristian mentioned this issue Sep 24, 2020
Merged
5 tasks
@brchristian
Copy link
Contributor Author

Great, that sounds good! And it also makes it consistent with other backend views as well, e.g., orders/confirm/_customer_details and others. I have submitted a PR at #3773.

DanielePalombo pushed a commit to DanielePalombo/solidus that referenced this issue Oct 30, 2020
@brchristian @DanielePalombo
Display billing address to left of shipping address
7b32e7d 
This makes the backend views consistent with the frontend.
Fixes solidusio#3771
aldesantis pushed a commit to aldesantis/solidus that referenced this issue Dec 28, 2020
@brchristian @aldesantis
Display billing address to left of shipping address
935bf4c 
This makes the backend views consistent with the frontend.
Fixes solidusio#3771
aldesantis pushed a commit to aldesantis/solidus that referenced this issue Dec 28, 2020
@brchristian @aldesantis
Display billing address to left of shipping address
5baa22e 
This makes the backend views consistent with the frontend.
Fixes solidusio#3771
mamhoff pushed a commit to mamhoff/solidus that referenced this issue Feb 1, 2021
@brchristian @mamhoff
Display billing address to left of shipping address
61299d4 
This makes the backend views consistent with the frontend.
Fixes solidusio#3771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display billing address to left of shipping address brchristian/solidus
4 participants
@tvdeyen @kennyadsl @aldesantis @brchristian