Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix responders gem dependency #3336

Merged
merged 2 commits into from
Sep 18, 2019
Merged

Fix responders gem dependency #3336

merged 2 commits into from
Sep 18, 2019

Commits on Sep 16, 2019

  1. Add responders as explicit dependency of solidus_frontend 

    We are using respond_with in solidus_frontend controllers but
this dependency is not explicit in the gemspec.

It is working now because it's a dependency of solidus_api (and
solidus_auth_devise).
    @kennyadsl
    kennyadsl committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    584ba3b View commit details
    Browse the repository at this point in the history

  2. Add responders gem as solidus_backend dependency 

    It is now loaded and required through solidus_api (and
solidus_auth_devise if included) but respond_with is widely used
and it is better to explicitely require it.
    @kennyadsl
    kennyadsl committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    aa42135 View commit details
    Browse the repository at this point in the history