Fix responders gem dependency #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using respond_with in solidus_frontend controllers but this dependency is not explicit in the gemspec. It is working now because it's a dependency of solidus_api (and solidus_auth_devise).
It is now loaded and required through solidus_api (and solidus_auth_devise if included) but respond_with is widely used and it is better to explicitely require it.
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Jun 16, 2023
We removed the responders dependency from solidus_core in solidusio#2090. However, we forgot to remove the use of the responders API from solidus_core. We weren't catching this because all consumers of solidus_core's `Spree::BaseController` had the responders gen as a dependency (see solidusio#3336)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We removed
respondersgem dependency from core with #2090 but we are usingrespond_within bothsolidus_frontendandsolidus_backendcontrollers.It is working because the dependency is satisfied by
solidus_api(andsolidus_auth_devisesincerespondersis a directdevisedependency as well).This dependency is currently not explicit in
solidus_frontendandsolidus_backendgemspecs. This PR fixes this issue.Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)