Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make preferences usage uniform across all Solidus gems #3267

Merged
merged 7 commits into from
Jul 18, 2019
Merged

Make preferences usage uniform across all Solidus gems #3267

merged 7 commits into from
Jul 18, 2019

Commits on Jul 18, 2019

  1. Move backend_configuration from /app to /lib 

    It has nothing to do with Rails anymore and follows the style
of what we do in core
    @kennyadsl
    kennyadsl committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    5c0ee20 View commit details
    Browse the repository at this point in the history

  2. Move frontend_configuration from /app to /lib 

    It has nothing to do with Rails anymore and follows the style
of what we do in core
    @kennyadsl
    kennyadsl committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    eafbc3c View commit details
    Browse the repository at this point in the history

  3. Move api_configuration from /app to /lib 

    It has nothing to do with Rails anymore and follows the style
of what we do in core
    @kennyadsl
    kennyadsl committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    fbc8d6b View commit details
    Browse the repository at this point in the history

  4. Use I18n.default_locale instead of the Rails.config as default 

    This is needed because, when these files are loaded, we don't have the
Rails app initialized yet. We are safe since the defaults are also
set in the spree.rb initializer template:

https://github.com/solidusio/solidus/blob/be1534d0d9b57d33e80f8c7f36d0e2efe219ada6/core/lib/generators/spree/install/templates/config/initializers/spree.rb.tt#L71

so everyone should have these preferences set
    @kennyadsl
    kennyadsl committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    11d9a85 View commit details
    Browse the repository at this point in the history

  5. Remove useless Spree::Api module definition

    @kennyadsl
    kennyadsl committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    762d49d View commit details
    Browse the repository at this point in the history

  6. Remove usless require of rails/engine

    @kennyadsl
    kennyadsl committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    a87f7cb View commit details
    Browse the repository at this point in the history

  7. Require responders where it is actually used for api

    @kennyadsl
    kennyadsl committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    d42be43 View commit details
    Browse the repository at this point in the history