Make preferences usage uniform across all Solidus gems #3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
added
Code Review Needed
changelog:solidus_core
spaghetticode
approved these changes
Jul 16, 2019
gmacdougall
approved these changes
Jul 17, 2019
It has nothing to do with Rails anymore and follows the style of what we do in core
It has nothing to do with Rails anymore and follows the style of what we do in core
It has nothing to do with Rails anymore and follows the style of what we do in core
This is needed because, when these files are loaded, we don't have the Rails app initialized yet. We are safe since the defaults are also set in the spree.rb initializer template: https://github.com/solidusio/solidus/blob/be1534d0d9b57d33e80f8c7f36d0e2efe219ada6/core/lib/generators/spree/install/templates/config/initializers/spree.rb.tt#L71 so everyone should have these preferences set
kennyadsl
force-pushed
the
kennyadsl/move-preferences-to-lib
branch
from
dd18e61
to
d42be43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #2178 we moved
AppConfigurationincorefromapp/tolib/.This PR continues that work by moving also Backend, Frontend, and API configuration classes from
app/tolib/.The only important thing, in my opinion, is that we cannot use
Rails.application.config.i18n.default_localeanymore, since the Rails application is not been booted yet. UsingI18n.default_localeshould be the same, and the default should not be used by anyone, since we also have the preference set into thespree.rbinitializer template that we inject into the host application.Checklist: