Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use backbone StateSelect view for stock locations form #2542

Merged
merged 2 commits into from
Feb 5, 2018
Merged

Use backbone StateSelect view for stock locations form #2542

merged 2 commits into from
Feb 5, 2018

Commits on Jan 31, 2018

  1. Use backbone StateSelect view for stock locations 

    This was using the old update_state function which was no longer used by
the customer address page. It worked okay, but was pretty clunky.

This commit changes the stock locations page to use the same
Views.StateSelect backbone view that the customer details page uses.
This allows removing the inline JS on that page, and removes the last
use of the update_state global.

This also makes the behaviour of Views.StateSelect better when no
country is selected. It now shows the state selector in a disabled
state.
    @jhawthorn
    jhawthorn committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    44ba746 View commit details
    Browse the repository at this point in the history

  2. Remove JS update_state

    @jhawthorn
    jhawthorn committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    ba16260 View commit details
    Browse the repository at this point in the history