Use backbone StateSelect view for stock locations form #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was using the old update_state function which was no longer used by the customer address page. It worked okay, but was pretty clunky. This commit changes the stock locations page to use the same Views.StateSelect backbone view that the customer details page uses. This allows removing the inline JS on that page, and removes the last use of the update_state global. This also makes the behaviour of Views.StateSelect better when no country is selected. It now shows the state selector in a disabled state.
jhawthorn
force-pushed
the
stock_locations_states
branch
from
c784532
to
ba16260
Compare
gmacdougall
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was using the old
update_statefunction which was no longer used by the customer address page. It worked okay, but was pretty clunky.This commit changes the stock locations page to use the same
Views.StateSelectbackbone view that the customer details page uses. This allows removing the inline JS on that page, and removes the lastuse of the
update_stateglobal.This also makes the behaviour of
Views.StateSelectbetter when no country is selected. It now shows the state selector in a disabled state.