Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for repair adjustments code #1474

Merged
merged 4 commits into from
Oct 4, 2016
Merged

Fix for repair adjustments code #1474

merged 4 commits into from
Oct 4, 2016

Commits on Sep 27, 2016

  1. Improve adjustment-repair error message and add specs

    @jordan-brough
    jordan-brough committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    8132da5 View commit details
    Browse the repository at this point in the history

  2. Fix for Adjustment#repair_adjustments_associations_on_create 

    When the item gets deleted before after_commit runs.

I ran into this while working on some changes where some tax
adjustments would get created and destroyed in the same transaction.
    @jordan-brough
    jordan-brough committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    2ad67d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2016

  1. Use destroyed? instead of exists? 

    To avoid a query
    @jordan-brough
    jordan-brough committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    2c695ab View commit details
    Browse the repository at this point in the history

  2. Fix spec text

    @jordan-brough
    jordan-brough committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    0d8aac4 View commit details
    Browse the repository at this point in the history