Fix for repair adjustments code #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the item gets deleted before after_commit runs. I ran into this while working on some changes where some tax adjustments would get created and destroyed in the same transaction.
jordan-brough
force-pushed
the
fix-for-repair-adjustments-code
branch
from
915d1f3
to
2ad67d2
Compare
mamhoff
approved these changes
Sep 29, 2016
|
Whether this should be on the 1.4 and 2.0 branches is a decision I'd like to leave up to @jhawthorn. |
cbrunsdon
approved these changes
Sep 29, 2016
To avoid a query
|
Thanks @cbrunsdon & @mamhoff. @jhawthorn mentioned offline that it might be nice to avoid the query using @jhawthorn was also going to look at another way of attacking this problem that might allow using |
|
Note about 1.4: My specs don't work for 1.4 unfortunately :( since after_commit doesn't work correctly in specs in Rails <= 4. See this readme. |
|
@jhawthorn merging this for now so that I can rebase #1479 against master. I assume you'll open another PR if you get the other method working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Adjustment#repair_adjustments_associations_on_create
When the item gets deleted before after_commit runs.
I ran into this while working on some changes where some tax
adjustments would get created and destroyed in the same transaction.
Also add specs for this code.
See individual commits.
Is this worth adding to the 2.0 & 1.4 branches as well?