Use the same sidebar logic that Solidus uses #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the default static_content sidebar use the same logic that Solidus does in frontend/app/views/spree/products/index.html.erb. The positive consequence of this change is that now, by default, static content pages render the same default sidebar that Solidus pages do, unifying the look and feel and making the static content pages look "normal".
This commit replaces the Deface hook with a standard MenuItem approach to add the "Pages" entry into the Admin menu. Besides removing Deface, this change has an additional benefit that the Pages entry now behaves in the same way that the original Solidus admin menu entries do. (Previously, with Deface, the "Pages" entry was being added to the menu even on the Admin Login page, where the standard menu should remain empty.)
|
The change in the second commit seems to be incompatible with Solidus < 1.4. If this is a problem for the pull request to be merged, I could change the code to retain the Deface behavior for < 1.4, and use MenuItem for >= 1.4. (Advice on whether that's a good approach, and/or what to do instead would be appreciated.) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the default static_content sidebar use the same logic
that Solidus does in frontend/app/views/spree/products/index.html.erb.
The positive consequence of this change is that now, by default, static
content pages render the same default sidebar that Solidus pages do,
unifying the look and feel and making the static content pages look
"normal".