Fix the admin tab #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just confirmed this works locally! 🎉 |
tvdeyen
force-pushed
the
fixes-admin-tab
branch
2 times, most recently
from
d22a3d8
to
fe71b5b
Compare
In Solidus < 1.4 we still need a Deface override, but need to check the permissions of the user, so it does not appear in the login screen. For Solidus >= 1.4 we use the `Spree::Config::Backend::MenuItem` configuration.
There is no need to override the label attribute of the admin tab. Solidus will use the first argument and translates it for us.
tvdeyen
force-pushed
the
fixes-admin-tab
branch
from
fe71b5b
to
46d75ae
Compare
|
@tvdeyen what about merging this one? I think it's still an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Solidus < 1.4 we still need a Deface override, but need to check the permissions of the user, so it does not appear in the login screen.
For Solidus >= 1.4 we use the
Spree::Config::Backend::MenuItemconfiguration.