Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SigMFArchiveReader for fromfile() #264

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

jacobagilbert
Copy link
Member

Closes #244

Also cleans up SigMFFileError imports/usage.

@jacobagilbert
Copy link
Member Author

@gmabey does this seem like a reasonable way to address 244? I think we have accumulated a bit of architectural debt in the python module and it we can discuss that in the future (there is a circular import issue here which is why the import is inline) but that can be done once we get a functional release up.

@gmabey
Copy link
Contributor

gmabey commented Jan 6, 2023

Yes, looks very reasonable to me, although I have not yet actually tried it. And -- I appreciate those cleanups too.

@jacobagilbert
Copy link
Member Author

Thanks @gmabey ill hold on this until you can give it a spin, doesnt need to be merged today or anything... shooting for release next week or week after, and this should probably be in there.

@gmabey
Copy link
Contributor

gmabey commented Jan 10, 2023

I'm getting a Metadata in archive did not .validate()! that I didn't expect, but there's no detail. It looks like @jacobagilbert had that part commented out in #263.

Actually I've had that error pop up for a while, I just kept hoping it would go away when those validate PRs were finally merged. Is anyone else seeing that message?

@jacobagilbert
Copy link
Member Author

jacobagilbert commented Jan 10, 2023

Ah yea i should probably remove those lines here. validate() no longer returns a bool, it throws an exception if it fails so that check just prints that line for no reason. Thats a bug.

Edit: Give it a shot now.

@jacobagilbert
Copy link
Member Author

Concurrence on the call today, merging.

@jacobagilbert jacobagilbert merged commit 3b69e03 into sigmf-v1.x Jan 16, 2023
@jacobagilbert jacobagilbert deleted the archive_reader_simplification branch January 17, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SigMF archive error reading data file
2 participants