SigMF archive error reading data file

[Deschain]

I think that there is an error opening sigmf archive files. The compliant dataset file is no recognized as a valid file because the relative path of the tar member is used https://github.com/gnuradio/SigMF/blob/1eef44a67636ab15078e7eecc00144b9e18cdaa3/sigmf/sigmffile.py#L779

[lgoix]

dir = tempfile.mkdtemp()
dir is created before, we could pass it to the get_dataset_filename_from_metadata()

[jacobagilbert]

@gmabey - you are our resident expert on Archives, can you take a look at this issue in the latest codebase?

[gmabey]

@Deschain Yes, you are correct, there is a true problem with the current implementation. Unfortunately, my best suggestion right now is to use SigMFArchiveReader instead, like this:

import sigmf
rdr = sigmf.SigMFArchiveReader('/the/path/to.sigmf')
print(rdr.sigmffile)
print(rdr.shape)  # the shape of the datafile
print(rdr[:])  # accessing values in the datafile

@jacobagilbert do you think that SigMFFile.fromfile() should be deprecated?

[jacobagilbert]

I think we can fix this so that fromfile() can open all types including archives. Its used a lot.