Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add GitHub actions (#283) #284

Merged
merged 32 commits into from
Oct 15, 2019
Merged

chore: Add GitHub actions (#283) #284

merged 32 commits into from
Oct 15, 2019

Conversation

sathia27
Copy link
Contributor

@sathia27 sathia27 commented Oct 14, 2019 •
edited by amaury1093

fixes #283

Current steps:

  1. Checkout
  2. yarn install and lint
  3. yarn test

@sathia27
add GitHub actions (shootismoke#283)
d7486b8 
Current steps:
1. Checkout
2. yarn install and lint
3. yarn test
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@amaury1093 amaury1093 changed the title add GitHub actions (#283) chore: Add GitHub actions (#283) Oct 14, 2019
@sathia27
Sathia27 GitHub actions (#2)
6adfdf5 
* shootismoke#283 Add github actions

* fix(shootismoke#283): remove unused lines in github actions

* fix(shootismoke#283): remove yarn install

* fix(shootismoke#283): add checkout actions

* fix(shootismoke#283): add CI on PR
@amaury1093
Copy link
Member

Thanks! Hmm, I am not sure why the actions are not appearing in the checks. Maybe I should activate Actions first

@amaury1093
Copy link
Member

amaury1093 commented Oct 14, 2019 •
edited

Hey @sathia27, could you instead replace the existing main.yml (which I just created in #285). I believe after that the Actions will appear in the checks. Thanks a lot!

3 additional notes:

  • Could you create 2 separate jobs: one lint and one test (instead of running both in the same job)
  • Could you delete .travis.yml?
  • Could you replace the Travis badge with a Github action badge in the README?
[![Actions Status](https://github.com/{owner}/{repo}/workflows/{workflow_name}/badge.svg)](https://github.com/{owner}/{repo}/actions)

Thanks!

@sathia27
Copy link
Contributor Author 

* Github action badge

Sure will work on it.

@sathia27
feat(shootismoke#283): add github action badge, fix multi job
685b708
@sathia27
fix(shootismoke#283): fix yaml syntax
490b552
@sathia27
fix(shootismoke#283): fix yaml parsing issue - workflow
e6e76dd
@sathia27
fix(shootismoke#283): fix steps github actions
cf60675
@sathia27
test(shootismoke#283): test multi jobs
f7eeff3
@sathia27
test(shootismoke#283): test multiple jobs
9f9cf9e
@sathia27
test(shootismoke#283): test multi job in actions
e991347
@sathia27
test(shootismoke#283): test multi jobs with steps
0694500
@sathia27
test(test multi jobs):
fe7ef87
@sathia27
test(shootismoke#283): add multi jobs steps
162cddb
@sathia27
test(shootismoke#283): run multi jobs
a266134
@sathia27
test(shootismoke#283): add multi job action
fdb7357
@sathia27
test(shootismoke#283): multi jobs action
7f1e2b9
@sathia27
test(shootismoke#283): add runs-on in all jobs
bc31af8
@sathia27
test(shootismoke#283): add test job
839e22a
@sathia27
test(shootismoke#283): refactored jobs in github actions
754f8a2
@sathia27
fix(shootismoke#283): fix multi job issue - github actions
0d53dc5
@sathia27
test(shootismoke#283): fix multi job build
7eb5971
@sathia27
test(shootismoke#283): fix indentation
1269d60
@sathia27
feat(shootismoke#238): fix multi job failure
d3f54ed
@sathia27
test(shootismoke#283): add synchronous job
35e0d7d
@sathia27
test(shootismoke#283): fix yarn test
6da9641
@sathia27
Copy link
Contributor Author

sathia27 commented Oct 14, 2019 •
edited

@amaurymartiny

  1. Kept it as 2 seperate job for test and lint
  2. removed travis.yml
  3. added github badge in README

Please check and let me know if something needs to be changed.

amaury1093
amaury1093 reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! Just a small rename nit in your PR.

Could you fix the conflict?

.github/workflows/main.yml Outdated Show resolved Hide resolved
@sathia27
Copy link
Contributor Author

sathia27 commented Oct 15, 2019 •
edited

Thanks, this looks good! Just a small rename nit in your PR.

Could you fix the conflict?
@amaurymartiny
Done. Thank you.

@sathia27 sathia27 closed this Oct 15, 2019
@sathia27 sathia27 reopened this Oct 15, 2019
amaury1093
amaury1093 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@amaury1093 amaury1093 merged commit 037389f into shootismoke:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to Github Actions
3 participants
@sathia27 @CLAassistant @amaury1093