Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Github Actions #283

Closed
amaury1093 opened this issue Oct 14, 2019 · 2 comments · Fixed by #284
Closed

Switch to Github Actions #283

amaury1093 opened this issue Oct 14, 2019 · 2 comments · Fixed by #284
Assignees
@sathia27
Labels
good first issue Good for newcomers

Comments

@amaury1093
Copy link
Member

To remove the amount of external dependencies (here travis), I'd like to try Github Actions for this project.

It'll be simple: just create 2 worksflows, first one run yarn lint, second one yarn test
@sathia27
Copy link
Contributor

@amaurymartiny can I take this up?

@amaury1093
Copy link
Member Author

Sure, go ahead!

sathia27 added a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
@sathia27
shootismoke#283 Add github actions
7487004
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
fix(shootismoke#283): remove unused lines in github actions
5c0e99c
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
fix(shootismoke#283): remove yarn install
db730e3
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
fix(shootismoke#283): add checkout actions
419cd4b
sathia27 added a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
@sathia27
add GitHub actions (shootismoke#283)
d7486b8 
Current steps:
1. Checkout
2. yarn install and lint
3. yarn test
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
fix(shootismoke#283): add CI on PR
97afb15
sathia27 added a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
@sathia27
Sathia27 GitHub actions (#2)
6adfdf5 
* shootismoke#283 Add github actions

* fix(shootismoke#283): remove unused lines in github actions

* fix(shootismoke#283): remove yarn install

* fix(shootismoke#283): add checkout actions

* fix(shootismoke#283): add CI on PR
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
fix(shootismoke#283): test and setup as multiple job, remove travis
59d4e15
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
feat(shootismoke#283): add github action badge, fix multi job
685b708
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
fix(shootismoke#283): fix yaml syntax
490b552
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
fix(shootismoke#283): fix yaml parsing issue - workflow
e6e76dd
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
fix(shootismoke#283): fix steps github actions
cf60675
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): test multi jobs
f7eeff3
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): test multiple jobs
9f9cf9e
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): test multi job in actions
e991347
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): test multi jobs with steps
0694500
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): add multi jobs steps
162cddb
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): run multi jobs
a266134
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): add multi job action
fdb7357
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): multi jobs action
7f1e2b9
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): add runs-on in all jobs
bc31af8
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): add test job
839e22a
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): refactored jobs in github actions
754f8a2
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
fix(shootismoke#283): fix multi job issue - github actions
0d53dc5
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): fix multi job build
7eb5971
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): fix indentation
1269d60
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): add synchronous job
35e0d7d
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): fix yarn test
6da9641
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
ci(shootismoke#283): fix multi job failures
d30ffac
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
test(shootismoke#283): run multi jobs
14745d6
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
ci(shootismoke#283): run yarn test without install
96abd49
sathia27 pushed a commit to sathia27/shoot-i-smoke that referenced this issue Oct 14, 2019
ci(shootismoke#283): run yarn test in separate job
970042f
@sathia27 sathia27 mentioned this issue Oct 15, 2019
Merged
amaury1093 added a commit that referenced this issue Oct 15, 2019
@sathia27 @amaury1093
chore: Add GitHub actions (#284)
037389f 
* add GitHub actions (#283)

Current steps:
1. Checkout
2. yarn install and lint
3. yarn test

* Sathia27 GitHub actions (#2)

* #283 Add github actions

* fix(#283): remove unused lines in github actions

* fix(#283): remove yarn install

* fix(#283): add checkout actions

* fix(#283): add CI on PR

* fix(#283): test and setup as multiple job, remove travis

* feat(#283): add github action badge, fix multi job

* fix(#283): fix yaml syntax

* fix(#283): fix yaml parsing issue - workflow

* fix(#283): fix steps github actions

* test(#283): test multi jobs

* test(#283): test multiple jobs

* test(#283): test multi job in actions

* test(#283): test multi jobs with steps

* test(test multi jobs):

* test(#283): add multi jobs steps

* test(#283): run multi jobs

* test(#283): add multi job action

* test(#283): multi jobs action

* test(#283): add runs-on in all jobs

* test(#283): add test job

* test(#283): refactored jobs in github actions

* fix(#283): fix multi job issue - github actions

* test(#283): fix multi job build

* test(#283): fix indentation

* feat(#238): fix multi job failure

* test(#283): add synchronous job

* test(#283): fix yarn test

* test(#238): moving from yaml to workflow

* ci(#283): fix multi job failures

* test(#283): run multi jobs

* ci(#283): run yarn test without install

* ci(#283): run yarn test in separate job

* Update .github/workflows/main.yml

Co-Authored-By: Amaury Martiny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sathia27 sathia27

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add GitHub actions (#283) sathia27/shoot-i-smoke
2 participants
@sathia27 @amaury1093